Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT - UX Pending] [Upload status screen] Improve link, title, and status labels #2882

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Nov 27, 2024

Closes #2866

<string name="upload_pending">Pending</string>
<string name="photos_pending">Photos pending</string>
<string name="photos_pending_retry">Photos pending retry</string>
<string name="uploading_photos">Uploading photos</string>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amegantz Could you PTAL at these to see if they work?

@jo-spek Once @amegantz approves, do you have someone who could verify the French, Spanish, and Portuguese translations I added to other strings.xml files?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gino-m, yes, as agreed upon in the stand-up, I'll regularly keep an eye on these! Please tag me whenever you add something to strings.xml.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're doing a small redesign of this screen so I'll pause this PR for now. Will def keep you posted on updated/new strings!

@gino-m gino-m marked this pull request as ready for review November 27, 2024 17:19
@gino-m gino-m requested review from amegantz and removed request for sufyanAbbasi and anandwana001 November 27, 2024 17:19
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.68%. Comparing base (9ab91bc) to head (f82f0db).

Files with missing lines Patch % Lines
...oogle/android/ground/ui/syncstatus/SyncListItem.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2882   +/-   ##
=========================================
  Coverage     61.68%   61.68%           
  Complexity     1173     1173           
=========================================
  Files           268      268           
  Lines          6344     6344           
  Branches        876      876           
=========================================
  Hits           3913     3913           
  Misses         1890     1890           
  Partials        541      541           
Files with missing lines Coverage Δ
...oogle/android/ground/ui/syncstatus/SyncListItem.kt 0.00% <0.00%> (ø)

@amegantz
Copy link

amegantz commented Dec 3, 2024

I suggest "Retry pending" -> "Retrying", and "Photos pending retry" to "Retrying photo upload". This is to remove confusion about the user having to initiate the retry themselves, or the client retrying on its own.

Apologies for not catching that sooner. Everything else LGTM.

@gino-m gino-m changed the title [Upload status screen] Improve link, title, and status labels [DRAFT - UX Pendng] [Upload status screen] Improve link, title, and status labels Dec 6, 2024
@gino-m gino-m changed the title [DRAFT - UX Pendng] [Upload status screen] Improve link, title, and status labels [DRAFT - UX Pending] [Upload status screen] Improve link, title, and status labels Dec 6, 2024
@gino-m gino-m marked this pull request as draft December 6, 2024 19:09
@gino-m
Copy link
Collaborator Author

gino-m commented Dec 6, 2024

Moving to draft until we can finalize #2866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data sync status] Improve sync status labels and/or UX
5 participants