-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT - UX Pending] [Upload status screen] Improve link, title, and status labels #2882
base: master
Are you sure you want to change the base?
Conversation
<string name="upload_pending">Pending</string> | ||
<string name="photos_pending">Photos pending</string> | ||
<string name="photos_pending_retry">Photos pending retry</string> | ||
<string name="uploading_photos">Uploading photos</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @gino-m, yes, as agreed upon in the stand-up, I'll regularly keep an eye on these! Please tag me whenever you add something to strings.xml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're doing a small redesign of this screen so I'll pause this PR for now. Will def keep you posted on updated/new strings!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2882 +/- ##
=========================================
Coverage 61.68% 61.68%
Complexity 1173 1173
=========================================
Files 268 268
Lines 6344 6344
Branches 876 876
=========================================
Hits 3913 3913
Misses 1890 1890
Partials 541 541
|
I suggest "Retry pending" -> "Retrying", and "Photos pending retry" to "Retrying photo upload". This is to remove confusion about the user having to initiate the retry themselves, or the client retrying on its own. Apologies for not catching that sooner. Everything else LGTM. |
Moving to draft until we can finalize #2866. |
Closes #2866