Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on context from view models #2713

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Sep 5, 2024

@shobhitagarwal1612 shobhitagarwal1612 merged commit adddd9c into master Sep 5, 2024
2 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the remove-resource branch September 5, 2024 16:55
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (c83bca4) to head (3a9ec4d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...acollection/tasks/polygon/DrawAreaTaskViewModel.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2713      +/-   ##
============================================
- Coverage     61.00%   60.95%   -0.05%     
  Complexity     1162     1162              
============================================
  Files           264      264              
  Lines          6052     6045       -7     
  Branches        828      828              
============================================
- Hits           3692     3685       -7     
  Misses         1892     1892              
  Partials        468      468              
Files with missing lines Coverage Δ
.../ui/datacollection/tasks/date/DateTaskViewModel.kt 100.00% <100.00%> (ø)
...ion/tasks/location/CaptureLocationTaskViewModel.kt 44.44% <100.00%> (-1.99%) ⬇️
...asks/multiplechoice/MultipleChoiceTaskViewModel.kt 92.64% <100.00%> (-0.11%) ⬇️
...datacollection/tasks/number/NumberTaskViewModel.kt 100.00% <100.00%> (ø)
...i/datacollection/tasks/photo/PhotoTaskViewModel.kt 23.07% <100.00%> (ø)
...datacollection/tasks/point/DropPinTaskViewModel.kt 93.54% <100.00%> (ø)
.../ui/datacollection/tasks/text/TextTaskViewModel.kt 100.00% <100.00%> (ø)
.../ui/datacollection/tasks/time/TimeTaskViewModel.kt 100.00% <100.00%> (ø)
...acollection/tasks/polygon/DrawAreaTaskViewModel.kt 89.04% <50.00%> (-0.15%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code health] Android Resources in ViewModel is not good practice
2 participants