Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remote storage path for photos #2696

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Fix remote storage path for photos #2696

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc4c780
Fix remote storage path for photos
shobhitagarwal1612 Aug 24, 2024
3eac5ef
Merge branch 'master' into ashobhit/2695/photo-path
shobhitagarwal1612 Aug 26, 2024
bb6bfaa
Merge branch 'master' into ashobhit/2695/photo-path
shobhitagarwal1612 Aug 27, 2024
022225d
Merge branch 'master' into ashobhit/2695/photo-path
gino-m Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...c/main/java/com/google/android/ground/ui/datacollection/tasks/photo/PhotoTaskViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
val bitmap = rotateBitmap(bitmapUtil.fromUri(uri), rotateDegrees)
val file = userMediaRepository.savePhoto(bitmap, currentTask)
userMediaRepository.addImageToGallery(file.absolutePath, file.name)
val remoteFilename = FirebaseStorageManager.getRemoteMediaPath(surveyId, file.absolutePath)
val remoteFilename = FirebaseStorageManager.getRemoteMediaPath(surveyId, file.name)

Check warning on line 82 in ground/src/main/java/com/google/android/ground/ui/datacollection/tasks/photo/PhotoTaskViewModel.kt

View check run for this annotation

Codecov / codecov/patch

ground/src/main/java/com/google/android/ground/ui/datacollection/tasks/photo/PhotoTaskViewModel.kt#L82 

Added line #L82 was not covered by tests
setValue(PhotoTaskData(remoteFilename))
} catch (e: IOException) {
Timber.e(e, "Error getting photo selected from storage")
Expand Down