UI: Constrain task layouts to avoid overlap. #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes google#2516 by constraining our task container to the position of the action button dock. This ensures long multiple choice tasks aren't covered by the action buttons—the scroll region is limited to viewable area above the action button drawer.
shobhitagarwal1612
approved these changes
Jul 27, 2024
shobhitagarwal1612
requested changes
Jul 27, 2024
|
Weirdly enough, when I test this manually the date/time pickers are indeed visible, but now the tests are failing. |
|
Ok, failure stems from height="0dp", but this is what we want for actual rendering purposes. Any ideas how/why roboelectric/espresso fails to perform tasks on these kinds of views? |
The previous change (setting the task container layout to 0dp) causes espresso actions to fail in our tests on these views. Normally, android computes the height correctly given view constraints, but this doesn't appear to take place in our tests. For now, fix this by forcing the view to have a height of 1, so that the action may be performed.
* Upgrade versioner plugin * Fix gitversioner path
* Rename unit test target * Always generate code coverage report * Run tests against devDebug * Update path of report * Upgrade versioner version * Upgrade versioner plugin * Fix gitversioner path
|
Well, the gcb failed, and it's unclear to me why, but I've confirmed that the tests are working locally. |
shobhitagarwal1612
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2516 by constraining our task container to the position of the action button dock. This ensures long multiple choice tasks aren't covered by the action buttons—the scroll region is limited to viewable area above the action button drawer.
Screen.Recording.2024-07-26.at.3.05.25.PM.mov