Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the "Other" Option Now Disables the Other Text and Hides the Keyboard #2528

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
91a4b5e
Nudurupati surya 2 2397 (#1)
NudurupatiSurya Apr 10, 2024
8ddb7b3
Merge branch 'master' into master
NudurupatiSurya Apr 10, 2024
a67dbde
Reverted the deletion of google-services.json
NudurupatiSurya Apr 10, 2024
2d931f2
Merge branch 'master' of https://github.com/NudurupatiSurya/ground-an…
NudurupatiSurya Apr 10, 2024
53e7f07
added few imports
NudurupatiSurya Apr 10, 2024
6881b41
Merge remote-tracking branch 'upstream/master'
NudurupatiSurya Apr 14, 2024
4dfa529
Modified code to adhere to SRP
NudurupatiSurya Apr 14, 2024
0de7b3e
added google-services.json
NudurupatiSurya Apr 14, 2024
bf8f60a
some refactoring
NudurupatiSurya Apr 14, 2024
53115ec
Merge branch 'master' into master
NudurupatiSurya Apr 23, 2024
4054059
Made suggested changes
NudurupatiSurya Apr 23, 2024
b6c01a0
Rearranged the order of buttons in the dialog.
NudurupatiSurya Apr 24, 2024
4fefe6c
Modified Nav Header
NudurupatiSurya Apr 24, 2024
6926c21
Modified font family and marginEnd for user photo in navigation drawer
NudurupatiSurya Apr 30, 2024
f1268cb
Changed font to SP & marginEnd for user photo to DP
NudurupatiSurya May 9, 2024
52f10d7
Merge branch 'master' into master
NudurupatiSurya May 9, 2024
7c484e9
Merge branch 'master' into master
shobhitagarwal1612 May 13, 2024
cc51e2c
Made requested changes
NudurupatiSurya May 20, 2024
64662bd
Merge branch 'master' of https://github.com/NudurupatiSurya/ground-an…
NudurupatiSurya May 20, 2024
237690e
Merge branch 'master' into master
NudurupatiSurya May 20, 2024
fb9de96
Fixed Lint Errors
NudurupatiSurya May 23, 2024
6f75d7a
Merge branch 'master' of https://github.com/NudurupatiSurya/ground-an…
NudurupatiSurya May 23, 2024
1ef7dea
Merge branch 'master' into master
gino-m May 28, 2024
8186ac9
Fixed issue #2399
NudurupatiSurya Jun 28, 2024
e7426ce
Merge branch 'google:master' into master
NudurupatiSurya Jun 28, 2024
17e32cf
Merge branch 'google:master' into master
NudurupatiSurya Jul 20, 2024
fee03ef
Merge branch 'master' into master
gino-m Jul 30, 2024
e6c39a8
Merge branch 'master' into master
gino-m Aug 7, 2024
1dbad1c
Merge branch 'master' into master
shobhitagarwal1612 Aug 29, 2024
e0fc5a0
Merge branch 'master' into master
gino-m Nov 20, 2024
ab7327b
Merge branch 'master' into master
gino-m Dec 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ class MultipleChoiceTaskViewModel @Inject constructor(resources: Resources) :
}
}

fun isOtherOptionAndSelected(item: MultipleChoiceItem): Boolean =
item.isOtherOption && item.isSelected

companion object {
private const val OTHER_ID: String = "OTHER_ID"
private const val OTHER_PREFIX: String = "[ "
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
android:inputType="text"
android:text="@{item.otherText}"
android:visibility="@{item.isOtherOption ? View.VISIBLE: View.GONE}"
android:enabled="@{viewModel.isOtherOptionAndSelected(item)}"
app:textChangedListener="@{viewModel.otherTextWatcher}" />
</com.google.android.material.textfield.TextInputLayout>
</androidx.constraintlayout.widget.ConstraintLayout>
Expand Down