-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support conditional branching for task progression #2255
Conversation
… branching on tasks.
…e next and previous tasks.
- Note, need to remove logs before finalizing.
- Also formatting etc.
ground/src/main/java/com/google/android/ground/model/task/Condition.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/model/task/Condition.kt
Outdated
Show resolved
Hide resolved
...main/java/com/google/android/ground/persistence/remote/firebase/schema/ConditionConverter.kt
Outdated
Show resolved
Hide resolved
...main/java/com/google/android/ground/persistence/remote/firebase/schema/ConditionConverter.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # ground/src/main/java/com/google/android/ground/persistence/local/room/converter/ConverterExt.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few initial comments, review still WIP.
ground/src/main/java/com/google/android/ground/model/task/Condition.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/persistence/local/room/converter/ConverterExt.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/persistence/local/room/converter/ConverterExt.kt
Outdated
Show resolved
Hide resolved
...main/java/com/google/android/ground/persistence/remote/firebase/schema/ConditionConverter.kt
Outdated
Show resolved
Hide resolved
...main/java/com/google/android/ground/persistence/remote/firebase/schema/ConditionConverter.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/ui/datacollection/DataCollectionViewModel.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/model/task/Condition.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/model/task/Condition.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/model/task/Condition.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/persistence/local/room/converter/ConverterExt.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/persistence/local/room/entity/TaskEntity.kt
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/ui/datacollection/DataCollectionViewModel.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/ui/datacollection/DataCollectionViewModel.kt
Outdated
Show resolved
Hide resolved
…oogle/ground-android into sufy/1995/conditional-branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Fixed those last minute code formatting, sorry about that! Doing one more test to make sure and then merging. Working as intended! Ready to ship!! |
W000t!!! |
Fixes #1955
@gino-m