[sufyanAbbasi]

Fixes #2110

Sets the draw tool to a static color and sets the draw target to be an open circle, allowing for better view of the data underneath.

• Redraws the draw vertex to be an open circle, which will allow users to see the point underneath.
• Renders a small bull's eye at the selected point (due to technical limitations with the line string).
• Sets a static color for the entire draw tool.
• Implement the distance calculation (out of scope?).

• Tests pass.
• Created a survey with a polygon selection job.
• Verified that the draw tool is rerendered and produces valid geometries.

@gino-m

[gino-m]

Sorry to ask, but we just finalized the designs here:

Any chance you could update the styling to match? Just asked @rawbzz to confirm whether the color should match the polygon (job color) or be fixed. Thanks for your patience!

[sufyanAbbasi]

Yes! No worries, happy to refactor!

[sufyanAbbasi]

And I'm assuming that we'll be using the white circle to indicate the vertices, including the endcap, but the plus-sign is going to move independently on its own when panning, to minimize occlusion of the base layer?

[sufyanAbbasi]

PTAL!

[gino-m]

And I'm assuming that we'll be using the white circle to indicate the vertices, including the endcap, but the plus-sign is going to move independently on its own when panning, to minimize occlusion of the base layer?

Hey I hadn't thought of that, but it's a great idea. The only this is that this will only work because of a bug / incomplete FR where the edge only snaps to the map center when the camera stops moving. But the way you've done it makes this a feature rather than a bug, so LGTM. @rawbzz FYI

[gino-m]

A few suggestions. Thanks!

[gino-m]

P.S. Run Gradle target ktfmtFormat to fix formatting issues.

[gino-m]

⭕ LGTM!

[shobhitagarwal1612]

> Task :workspace:detekt FAILED
/workspace/ground/src/main/java/com/google/android/ground/ui/util/ColorUtil.kt:25:5: Functions with exact one statement, the return statement, can be rewritten with ExpressionBodySyntax. [ExpressionBodySyntax]

Some code quality checks are still failing. You can run these checks locally via gradle target checkCode

[sufyanAbbasi]

> Task :workspace:detekt FAILED
/workspace/ground/src/main/java/com/google/android/ground/ui/util/ColorUtil.kt:25:5: Functions with exact one statement, the return statement, can be rewritten with ExpressionBodySyntax. [ExpressionBodySyntax]

Some code quality checks are still failing. You can run these checks locally via gradle target checkCode

Thank you! Turns out the whole file can be deleted, as it is now unused. Done.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.42%. Comparing base (c5a130e) to head (f1952f9).
⚠️ Report is 443 commits behind head on master.

Files with missing lines	Patch %	Lines
...d/ground/ui/map/gms/features/LineStringRenderer.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #2241   +/-   ##
=========================================
  Coverage     52.42%   52.42%           
  Complexity     1222     1222           
=========================================
  Files           317      317           
  Lines          6264     6264           
  Branches        659      659           
=========================================
  Hits           3284     3284           
  Misses         2617     2617           
  Partials        363      363           

Files with missing lines	Coverage Δ
...acollection/tasks/polygon/DrawAreaTaskViewModel.kt	86.56% <ø> (ø)
...n/java/com/google/android/ground/ui/map/Feature.kt	85.00% <100.00%> (ø)
...d/ground/ui/map/gms/features/LineStringRenderer.kt	16.66% <0.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.