Make survey list reactive to local and remote changes #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gino-m
commented
Oct 30, 2023
ground/src/main/java/com/google/android/ground/repository/SurveyRepository.kt
Show resolved
Hide resolved
gino-m
commented
Oct 31, 2023
There was a problem hiding this comment.
@shobhitagarwal1612 Any idea why this test might be failing? Offline surveys should be shown first but it appears in the test they aren't.
value of: getText()
expected: survey 2
but was : survey 1
value of: getText()
expected: survey 2
but was : survey 1
at com.google.android.ground.ui.surveyselector.SurveySelectorFragmentTest.created_surveysAvailable_whenOneSurveySynced(SurveySelectorFragmentTest.kt:110)
gino-m
changed the title
Please disregard, latest commit fixes this. |
|
@shobhitagarwal1612 PTAL? |
1 similar comment
|
@shobhitagarwal1612 PTAL? |
...a/com/google/android/ground/persistence/remote/firebase/schema/SurveysCollectionReference.kt
Show resolved
Hide resolved
shobhitagarwal1612
requested changes
Oct 31, 2023
...nd/src/main/java/com/google/android/ground/persistence/remote/firebase/FirestoreDataStore.kt
Show resolved
Hide resolved
shobhitagarwal1612
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrade Firebase deps and introduces some minor refactors. Fixes #1973