Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Android app to use local emulator for development #2010

Merged
merged 21 commits into from
Oct 26, 2023
Merged

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Oct 24, 2023

This introduces two new variants dev and local to run against live dev Firebase and local FIrebase emulators, respectively. New debug build targets: devDebug and localDebug. Note that the latter currently only works from Android emulator.

Created to facilitate creation of test data for debugging google/ground-platform#1250.

@shobhitagarwal1612 PTAL?

@os-micmec FYI

@gino-m gino-m marked this pull request as ready for review October 26, 2023 02:56
@gino-m gino-m changed the title [WORK IN PROGRESS] Allow Android app to use local emulator for development Allow Android app to use local emulator for development Oct 26, 2023
@gino-m
Copy link
Collaborator Author

gino-m commented Oct 26, 2023

Hi @shobhitagarwal1612 I moved build variant logic into modules and refactored the test auth manager into its own class. PTAL?

Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gino-m gino-m merged commit af6c0ae into master Oct 26, 2023
4 checks passed
@gino-m gino-m deleted the gino-m/use-emu branch October 26, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants