-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update todo-to-list github action to commit to PR instead of master branch #2943
Conversation
3b7535e
to
aff28d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2943 +/- ##
=========================================
Coverage 62.22% 62.22%
Complexity 1205 1205
=========================================
Files 267 267
Lines 6380 6380
Branches 882 882
=========================================
Hits 3970 3970
Misses 1863 1863
Partials 547 547 |
@shobhitagarwal1612 Should we move this to draft for now? |
0e49ac6
to
c9ff361
Compare
381ed79
to
cccddbc
Compare
@gino-m The workflow isn't able to find the email if the workflow is run after PR is approved automation. |
Which email are you referring to? |
In order to bypass cla/google check, I added a step to get the email from |
I see. Only maintainers can push to this repo, so perhaps allowing creation of TODOs on commit is acceptable? |
Agreed. If you also agree, I can update this PR to run the workflow on each commit push. |
Sure, let's do it! |
Instead of merging the commit to master branch, it commits to the PR's source branch when the PR is approved.
@gino-m PTAL?