Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update todo-to-list github action to commit to PR instead of master branch #2943

Merged
merged 9 commits into from
Dec 23, 2024

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Dec 17, 2024

Instead of merging the commit to master branch, it commits to the PR's source branch when the PR is approved.

@gino-m PTAL?

@shobhitagarwal1612 shobhitagarwal1612 force-pushed the test-todo branch 2 times, most recently from 3b7535e to aff28d1 Compare December 17, 2024 13:04
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review December 17, 2024 13:09
@auto-assign auto-assign bot requested a review from gino-m December 17, 2024 13:09
@shobhitagarwal1612 shobhitagarwal1612 changed the title Test todo Update todo-to-list github action to commit to PR instead of master branch Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.22%. Comparing base (94c1ea7) to head (9cf4ae1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2943   +/-   ##
=========================================
  Coverage     62.22%   62.22%           
  Complexity     1205     1205           
=========================================
  Files           267      267           
  Lines          6380     6380           
  Branches        882      882           
=========================================
  Hits           3970     3970           
  Misses         1863     1863           
  Partials        547      547           

@gino-m
Copy link
Collaborator

gino-m commented Dec 18, 2024

@shobhitagarwal1612 Should we move this to draft for now?

@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as draft December 18, 2024 18:38
@shobhitagarwal1612 shobhitagarwal1612 force-pushed the test-todo branch 4 times, most recently from 0e49ac6 to c9ff361 Compare December 18, 2024 19:16
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review December 18, 2024 19:34
@auto-assign auto-assign bot requested a review from anandwana001 December 18, 2024 19:34
@shobhitagarwal1612 shobhitagarwal1612 removed the request for review from anandwana001 December 18, 2024 19:36
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as draft December 19, 2024 02:03
@shobhitagarwal1612
Copy link
Member Author

@gino-m The workflow isn't able to find the email if the workflow is run after PR is approved automation.

@gino-m
Copy link
Collaborator

gino-m commented Dec 23, 2024

@gino-m The workflow isn't able to find the email if the workflow is run after PR is approved automation.

Which email are you referring to?

@shobhitagarwal1612
Copy link
Member Author

In order to bypass cla/google check, I added a step to get the email from github.head_ref and use that when committing the new changes from workflow. This works fine when the workflow is executed on commit push. When the workflow is triggered on PR approval, then the step to get email doesn't work.

@gino-m
Copy link
Collaborator

gino-m commented Dec 23, 2024

In order to bypass cla/google check, I added a step to get the email from github.head_ref and use that when committing the new changes from workflow. This works fine when the workflow is executed on commit push. When the workflow is triggered on PR approval, then the step to get email doesn't work.

I see. Only maintainers can push to this repo, so perhaps allowing creation of TODOs on commit is acceptable?

@shobhitagarwal1612
Copy link
Member Author

I see. Only maintainers can push to this repo, so perhaps allowing creation of TODOs on commit is acceptable?

Agreed. If you also agree, I can update this PR to run the workflow on each commit push.

@gino-m
Copy link
Collaborator

gino-m commented Dec 23, 2024

I see. Only maintainers can push to this repo, so perhaps allowing creation of TODOs on commit is acceptable?

Agreed. If you also agree, I can update this PR to run the workflow on each commit push.

Sure, let's do it!

@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review December 23, 2024 17:08
@auto-assign auto-assign bot requested a review from anandwana001 December 23, 2024 17:08
@shobhitagarwal1612 shobhitagarwal1612 removed the request for review from anandwana001 December 23, 2024 17:09
@shobhitagarwal1612 shobhitagarwal1612 merged commit b0e408f into master Dec 23, 2024
5 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the test-todo branch December 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants