Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Navigator from HomeScreenFragment #2896

Merged
merged 14 commits into from
Dec 5, 2024

Conversation

anandwana001
Copy link
Collaborator

@anandwana001 anandwana001 commented Dec 4, 2024

Fixes #2895

Removed Navigator from
HomeScreenFragment
AbstractMapContainerFragment
DataCollectionFragment
PhotoTaskFragment
HomeScreenMapContainerFragment

@shobhitagarwal1612 @gino-m PTAL?

Base automatically changed from anandwana001/2776/navigate-directions-check to master December 5, 2024 03:07
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 22.50000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 61.57%. Comparing base (8349e55) to head (71d4810).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 0.00% 16 Missing ⚠️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 38.09% 12 Missing and 1 partial ⚠️
...ground/ui/datacollection/DataCollectionFragment.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2896      +/-   ##
============================================
- Coverage     61.62%   61.57%   -0.06%     
+ Complexity     1178     1176       -2     
============================================
  Files           269      269              
  Lines          6372     6361      -11     
  Branches        883      878       -5     
============================================
- Hits           3927     3917      -10     
+ Misses         1900     1899       -1     
  Partials        545      545              
Files with missing lines Coverage Δ
...ui/datacollection/tasks/photo/PhotoTaskFragment.kt 32.92% <ø> (+0.39%) ⬆️
...ogle/android/ground/ui/home/HomeScreenViewModel.kt 68.57% <100.00%> (-10.68%) ⬇️
...ground/ui/datacollection/DataCollectionFragment.kt 56.56% <0.00%> (+0.56%) ⬆️
...oogle/android/ground/ui/home/HomeScreenFragment.kt 58.87% <38.09%> (+3.87%) ⬆️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 16.86% <0.00%> (-0.20%) ⬇️

@anandwana001 anandwana001 merged commit 5bd180d into master Dec 5, 2024
4 checks passed
@anandwana001 anandwana001 deleted the anandwana001/2895/remove-navigator branch December 5, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code health] Remove Navigator
3 participants