-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Navigator from HomeScreenFragment #2896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
anandwana001/2776/navigate-directions-check
to
master
December 5, 2024 03:07
…or' into anandwana001/2895/remove-navigator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2896 +/- ##
============================================
- Coverage 61.62% 61.57% -0.06%
+ Complexity 1178 1176 -2
============================================
Files 269 269
Lines 6372 6361 -11
Branches 883 878 -5
============================================
- Hits 3927 3917 -10
+ Misses 1900 1899 -1
Partials 545 545
|
gino-m
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2895
Removed Navigator from
HomeScreenFragment
AbstractMapContainerFragment
DataCollectionFragment
PhotoTaskFragment
HomeScreenMapContainerFragment
@shobhitagarwal1612 @gino-m PTAL?