Disabling the "Other" Option Now Disables the Other Text and Hides the Keyboard

[NudurupatiSurya]

Fixes #2399

Demo:

Screen_recording_20240628_123808.mp4

@... PTAL?

[anandwana001]

Can we have a unit test to test this scenario?

[gino-m]

@NudurupatiSurya I believe to test this scenario you would want to add a UI test to MultipleChoiceTaskFragmentTest, since a unit test on MultipleChoiceTaskViewModel might be too trivial. @anandwana001 to confirm.

[anandwana001]

@NudurupatiSurya I believe to test this scenario you would want to add a UI test to MultipleChoiceTaskFragmentTest, since a unit test on MultipleChoiceTaskViewModel might be too trivial. @anandwana001 to confirm.

Yes,
We do have a file MultipleChoiceTaskFragmentTest.
@NudurupatiSurya You can once check the MultipleChoiceTaskFragmentTest and confirm if you can write a similar test to confirm this Other option disable thing.

[anandwana001]

Hi @NudurupatiSurya
Feel free to ask any question to make this PR to its completion.
Thanks

[anandwana001]

Gentle Reminder @NudurupatiSurya

[NudurupatiSurya]

MultipleChoiceTaskFragmentTest
Hi, Sorry for the delay. Thank you for your patience and feedback. I will update the PR by tomorrow.

[NudurupatiSurya]

Hi,

I wanted to give you a quick update. Before adding the new tests, I ran the existing ones in MultipleChoiceTaskFragmentTest.kt and found that the following tests are failing due to the recent changes:

• selects other option on text input and deselects other radio inputs
• no deselection of other option on text clear when not required
• no deselection of non-other selection when other is cleared
• deselects other option on text clear and required

I am currently working on resolving this and adding the new tests as suggested. I'll reach out if I get stuck anywhere. I should have an update for you later this week.

Thanks!

[anandwana001]

Hi @NudurupatiSurya

All the tests are passing for me. Could you please tell me how you are running the test cases?
also, is your branch up-to-date?

[anandwana001]

Hi @NudurupatiSurya
Gentle Reminder

[gino-m]

@NudurupatiSurya Updated branch here and rerunning test on CI to keep things moving foward.

/gcbrun

[gino-m]

@anandwana001 Confirmed tests are failing with the following when merged with HEAD:

com.google.android.ground.ui.datacollection.tasks.multiplechoice.MultipleChoiceTaskFragmentTest > selects other option on text input and deselects other radio inputs FAILED
    androidx.test.espresso.PerformException at MultipleChoiceTaskFragmentTest.kt:176
        Caused by: java.lang.RuntimeException at MultipleChoiceTaskFragmentTest.kt:176

com.google.android.ground.ui.datacollection.tasks.multiplechoice.MultipleChoiceTaskFragmentTest > no deselection of other option on text clear when not required FAILED
    androidx.test.espresso.PerformException at MultipleChoiceTaskFragmentTest.kt:210
        Caused by: java.lang.RuntimeException at MultipleChoiceTaskFragmentTest.kt:210

com.google.android.ground.ui.datacollection.tasks.multiplechoice.MultipleChoiceTaskFragmentTest > no deselection of non-other selection when other is cleared FAILED
    androidx.test.espresso.PerformException at MultipleChoiceTaskFragmentTest.kt:227
        Caused by: java.lang.RuntimeException at MultipleChoiceTaskFragmentTest.kt:227

com.google.android.ground.ui.datacollection.tasks.multiplechoice.MultipleChoiceTaskFragmentTest > deselects other option on text clear and required FAILED
    androidx.test.espresso.PerformException at MultipleChoiceTaskFragmentTest.kt:190
        Caused by: java.lang.RuntimeException at MultipleChoiceTaskFragmentTest.kt:190

@NudurupatiSurya Any updates?

[anandwana001]

ok,

I have the latest update, and tests are passing for me.
Let me try again and get back.

[NudurupatiSurya]

Hi @gino-m & @anandwana001,

I am currently in the process of some job interviews, so I couldn't reply back promptly.

@anandwana001, even after updating my current branch, these tests are failing

I think the tests are failing because the condition I added is overriding some of the otherText's previous behavior of selecting the other radio button when the user selects otherText.

All the failed tests are trying to write something in otherText before selecting the radio button. I removed the condition I wrote and these tests passed.

I will update my logic so that these tests will not fail and otherText shows the expected behavior. I will update this by next week as I am currently busy with job interviews.

Thank you for your understanding.

[jcqli]

Hi @NudurupatiSurya any updates?

[gino-m]

@NudurupatiSurya Are you able to finalize this PR within the next week or so? The following tests are failing:

> Task :ground:testLocalDebugUnitTest

com.google.android.ground.ui.datacollection.tasks.multiplechoice.MultipleChoiceTaskFragmentTest > selects other option on text input and deselects other radio inputs FAILED
    androidx.test.espresso.PerformException at MultipleChoiceTaskFragmentTest.kt:177
        Caused by: java.lang.RuntimeException at MultipleChoiceTaskFragmentTest.kt:177

com.google.android.ground.ui.datacollection.tasks.multiplechoice.MultipleChoiceTaskFragmentTest > no deselection of other option on text clear when not required FAILED
    androidx.test.espresso.PerformException at MultipleChoiceTaskFragmentTest.kt:211
        Caused by: java.lang.RuntimeException at MultipleChoiceTaskFragmentTest.kt:211

com.google.android.ground.ui.datacollection.tasks.multiplechoice.MultipleChoiceTaskFragmentTest > no deselection of non-other selection when other is cleared FAILED
    androidx.test.espresso.PerformException at MultipleChoiceTaskFragmentTest.kt:[228](https://github.com/google/ground-android/actions/runs/11942397209/job/33289359379?pr=2528#step:5:229)
        Caused by: java.lang.RuntimeException at MultipleChoiceTaskFragmentTest.kt:228

com.google.android.ground.ui.datacollection.tasks.multiplechoice.MultipleChoiceTaskFragmentTest > deselects other option on text clear and required FAILED
    androidx.test.espresso.PerformException at MultipleChoiceTaskFragmentTest.kt:191
        Caused by: java.lang.RuntimeException at MultipleChoiceTaskFragmentTest.kt:191

[gino-m]

I ran locally and verified that tests are still in fact failing, and that the behavior of this PR doesn't match what's being asked in #2399. I'll revise that ticket to make what's required more clear.