Skip to content

Commit

Permalink
Remove dependencyUpdates plugin (#2316)
Browse files Browse the repository at this point in the history
  • Loading branch information
shobhitagarwal1612 authored Mar 8, 2024
1 parent 49b520b commit 3593d16
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 236 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Ground for Android
[![cloud build status](https://storage.googleapis.com/gradle_cache_bucket/status.svg)](https://console.cloud.google.com/cloud-build/dashboard?project=ground-android-gcb)
[![codecov.io](https://codecov.io/github/google/ground-android/branch/master/graph/badge.svg)](https://codecov.io/github/google/ground-android)
[![dependency health](https://storage.googleapis.com/gradle_cache_bucket/dependency.svg)](https://storage.googleapis.com/gradle_cache_bucket/dependency.txt)
[![Open Source Helpers](https://www.codetriage.com/google/ground-android/badges/users.svg)](https://www.codetriage.com/google/ground-android)

Ground is an open-source, map-first data collection and analysis platform built
Expand Down
28 changes: 0 additions & 28 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ buildscript {
google()
mavenLocal()
maven { url "https://maven.google.com" }
maven { url "https://github.com/ben-manes/gradle-versions-plugin/raw/mvnrepo" }
maven { url "https://plugins.gradle.org/m2/" }
mavenCentral()
gradlePluginPortal()
Expand All @@ -55,7 +54,6 @@ buildscript {
}

plugins {
id "com.github.ben-manes.versions" version "0.51.0"
id "org.jetbrains.kotlin.android" version "$kotlinVersion" apply false
id "org.jetbrains.kotlin.plugin.serialization" version "$kotlinVersion"
id "com.ncorti.ktfmt.gradle" version "0.17.0"
Expand Down Expand Up @@ -111,32 +109,6 @@ gitVersioner {
baseBranch "master"
}

// https://github.com/ben-manes/gradle-versions-plugin/issues/746
apply plugin: 'jvm-ecosystem'

def isNonStable = { String version ->
def stableKeyword = ['RELEASE', 'FINAL', 'GA'].any { it -> version.toUpperCase().contains(it) }
def regex = /^[0-9,.v-]+(-r)?$/
return !stableKeyword && !(version ==~ regex)
}

// https://github.com/ben-manes/gradle-versions-plugin
// To check which dependencies are out of date:
// ./gradlew dependencyUpdates
tasks.dependencyUpdates {

// Disallow release candidates as upgradable versions from stable versions
rejectVersionIf {
isNonStable(it.candidate.version) && !isNonStable(it.currentVersion)
}

checkForGradleUpdate = true
checkConstraints = true
gradleReleaseChannel = "current"
outputFormatter = "json,plain"
outputDir = "ground/build/reports/dependencyUpdates"
}

ext {
androidCompileSdk = 34
androidMinSdk = 24
Expand Down
82 changes: 0 additions & 82 deletions cloud-builder/dependency.svg

This file was deleted.

108 changes: 0 additions & 108 deletions cloud-builder/generate_dependency_health_svg.py

This file was deleted.

17 changes: 0 additions & 17 deletions cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,6 @@ steps:
./gradlew -PdisablePreDex checkCode --no-daemon 2> check-logs.txt || echo "fail" > build-status.txt
cat check-logs.txt
if [[ "${_PUSH_TO_MASTER}" ]]; then
./gradlew -PdisablePreDex dependencyUpdates --no-daemon
fi
- name: 'gcr.io/$PROJECT_ID/android:34'
id: &unit_tests 'Run unit tests'
waitFor:
Expand Down Expand Up @@ -182,19 +178,6 @@ steps:
# Update build status if running on master branch
if [[ "${_PUSH_TO_MASTER}" ]]; then
# Gradle Dependencies Status
if [[ -f ground/build/reports/dependencyUpdates/report.json ]]; then
python cloud-builder/generate_dependency_health_svg.py ground/build/reports/dependencyUpdates/report.json dependency.svg
# Copy artifacts for Github badge
gsutil cp dependency.svg gs://${_CACHE_BUCKET}/dependency.svg
gsutil cp ground/build/reports/dependencyUpdates/report.txt gs://${_CACHE_BUCKET}/dependency.txt
# Makes files publicly readable
gsutil acl ch -u AllUsers:R gs://${_CACHE_BUCKET}/dependency.svg
gsutil acl ch -u AllUsers:R gs://${_CACHE_BUCKET}/dependency.txt
fi
# Build Status
if [ -f build-status.txt ] && [ $(< build-status.txt) == "fail" ]; then
gsutil cp cloud-builder/failure.svg gs://${_CACHE_BUCKET}/status.svg
Expand Down

0 comments on commit 3593d16

Please sign in to comment.