Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stack-legacy command to dump call traces in legacy format #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xaurx
Copy link
Contributor

@xaurx xaurx commented Oct 24, 2023

Unfortunately legacy format is more helpful in debug as it dumps goroutine labels. 'gops stack' doesn't dump them.

Golang issue: golang/go#63712

Unfortunately legacy format is more helpful in debug as it dumps
goroutine labels. 'gops stack' doesn't dump them.

Golang issue: golang/go#63712
Comment on lines +211 to +212
case signal.StackTraceLegacy:
return pprof.Lookup("goroutine").WriteTo(conn, 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a new command, would there be a way to pass the debug argument to the agent as part of the existing signal.StackTrace command? If this is not possible in a backwards-compatible way, I'd suggest instead to add a new more generic command which allows to pass the debug value as part of the command invocation, so users could e.g. use debug=0 to write in compressed format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants