Add annotate command for adding annotations for indexes and images#2119
Open
badstreff wants to merge 2 commits intogoogle:mainfrom
Open
Add annotate command for adding annotations for indexes and images#2119badstreff wants to merge 2 commits intogoogle:mainfrom
badstreff wants to merge 2 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@brandonmichigangithub Mind giving this a review? My first contrib to the project here so please let me know if there is a better way to bump PRs. (I looked for a community slack but couldn't find one) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to be able to add annotations to manifests (index or image) in a registry. Originally I was going to extend the mutate command to do this somehow but it makes a lot of assumptions that the manifest being mutated is an image and they code was getting pretty muddy adding logic to handle either.