feat: Add --healthcheck flag to crane mutate #2112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `--healthcheck` flag to the `crane mutate` command. The flag accepts a JSON string representing the OCI HealthConfig object. This allows users to set or modify the healthcheck configuration of an image. Includes a new e2e test script (`cmd/crane/cmd/mutate_test.sh`) to verify: - Setting a new healthcheck. - Overwriting an existing healthcheck. - Handling of invalid JSON input for the healthcheck flag. Note: Automated verification of tarball contents in the test script using `crane config` is currently hindered by issues with `crane config`'s handling of local tarball paths. The tests confirm that `crane mutate` produces tarballs and correctly errors on invalid input.
|
@brandonmichigangithub can you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new
--healthcheckflag to thecrane mutatecommand.The flag accepts a JSON string representing the OCI HealthConfig object. This allows users to set or modify the healthcheck configuration of an image.
Includes a new e2e test script (
cmd/crane/cmd/mutate_test.sh) to verify:Note: Automated verification of tarball contents in the test script using
crane configis currently hindered by issues withcrane config's handling of local tarball paths. The tests confirm thatcrane mutateproduces tarballs and correctly errors on invalid input.