Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support truncate log file for windows #960

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Support truncate log file for windows #960

merged 3 commits into from
Oct 8, 2023

Conversation

bqhuyy
Copy link
Contributor

@bqhuyy bqhuyy commented Oct 6, 2023

@bqhuyy bqhuyy force-pushed the windows_truncate_log_file branch from c6a750f to 1dddaae Compare October 6, 2023 05:07
sergiud
sergiud requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Just one remark.

src/logging.cc Outdated Show resolved Hide resolved
@bqhuyy bqhuyy requested a review from sergiud October 7, 2023 16:07
sergiud
sergiud requested changes Oct 7, 2023
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@bqhuyy bqhuyy requested a review from sergiud October 8, 2023 01:53
@sergiud sergiud added this to the 0.7 milestone Oct 8, 2023
@sergiud sergiud merged commit 4dbc26a into google:master Oct 8, 2023
135 checks passed
@Porkepix Porkepix mentioned this pull request Feb 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiud sergiud sergiud approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@bqhuyy @sergiud