-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump codecov/codecov-action from 3 to 4 #1071
build(deps): bump codecov/codecov-action from 3 to 4 #1071
Conversation
@dependabot rebase |
ee359c7
to
2c44983
Compare
@dependabot rebase |
2c44983
to
a94a043
Compare
@drigz We cannot update the Codecov action due to
Codecov changed the way the secret is accessed requiring to setup the corresponding token explicitly (per project?). However, I don't have access to these settings. Is there someone from the organization who can set |
@drigz Gentle ping. Any idea who can help here? |
Thanks for the ping, I overlooked the first message. I'll take a look! |
How sure are you that this is the explanation? I can't see any internal references for Not sure how to verify that though, other than just merging and rolling back if we see other codecov failures. WDYT? |
Nice, thanks. I have copied the secret from https://app.codecov.io/gh/google/glog/settings to https://github.com/google/glog/settings/secrets/dependabot. Let's see if this helps. |
@dependabot rebase |
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
a94a043
to
283f635
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
+ Coverage 60.52% 63.56% +3.03%
==========================================
Files 19 19
Lines 2574 2566 -8
Branches 917 895 -22
==========================================
+ Hits 1558 1631 +73
+ Misses 676 674 -2
+ Partials 340 261 -79 |
@drigz This works. Thank you! |
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps codecov/codecov-action from 3 to 4.
Release notes
Sourced from codecov/codecov-action's releases.
... (truncated)
Changelog
Sourced from codecov/codecov-action's changelog.
... (truncated)
Commits
e0b68c6
fix: show both token uses in readme (#1250)1f9f557
Add all args (#1245)09686fc
Update README.md (#1243)f30e495
fix: update action.yml (#1240)a7b945c
fix: allow for other archs (#1239)98ab2c5
Update package.json (#1238)43235cc
Update README.md (#1237)0cf8684
chore(ci): bump to node20 (#1236)8e1e730
build(deps-dev): bump@typescript-eslint/eslint-plugin
from 6.19.1 to 6.20.0 ...61293af
build(deps-dev): bump@typescript-eslint/parser
from 6.19.1 to 6.20.0 (#1235)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)