Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: give a example to show how to import glog by add_subdirectory #1067

Closed
wants to merge 0 commits into from

Conversation

valaxkong
Copy link

Change-Id: I2e77e155c134d36f36ff38f3d3bc396a48b07ff6

Copy link

google-cla bot commented Jan 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@valaxkong valaxkong mentioned this pull request Jan 22, 2024
Copy link
Collaborator

@sergiud sergiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I do not believe we should mirror the CMake documentation. An example of using FetchContent is better suited for the Wiki section of glog.

README.rst Outdated
@@ -79,6 +79,27 @@ Alternatively, glog can be incorporated into using the CMake command
project by replacing the :cmake:`find_package` call from the previous snippet by
:cmake:`add_subdirectory`. The :cmake:`glog::glog` target is in this case an
:cmake:`ALIAS` library target for the ``glog`` library target.
Here is an example which using :cmake:`FetchContent` and :cmake:`add_subdirectory`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to show a complete example for how to use FetchContent? This is essentially an exact mirror of the example from CMake reference documentation. In that sense, a single sentence with a link to FetchContent example should be sufficient.

@valaxkong valaxkong marked this pull request as draft January 22, 2024 12:40
@valaxkong valaxkong closed this Jan 23, 2024
@valaxkong
Copy link
Author

@sergiud
New PR: #1068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants