Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MODULE.bazel file #1059

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add MODULE.bazel file #1059

merged 1 commit into from
Jan 11, 2024

Conversation

Vertexwahn
Copy link
Contributor

Add MODULE.bazel file

@sergiud
Copy link
Collaborator

sergiud commented Jan 11, 2024

Thanks for the PR. Could you please briefly describe the purpose of this file in the commit message?

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e6fca9) 59.60% compared to head (4205185) 59.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   59.60%   59.60%           
=======================================
  Files          19       19           
  Lines        2604     2604           
  Branches      914      914           
=======================================
  Hits         1552     1552           
  Misses        712      712           
  Partials      340      340           

@sergiud sergiud requested a review from drigz January 11, 2024 07:11
@drigz
Copy link
Member

drigz commented Jan 11, 2024

MODULE.bazel will replace WORKSPACE as I understand it - although I'm not super up-to-date on this migration as I haven't been working with Bazel much lately :/ I assume @Vertexwahn has a good reason for not deleting WORKSPACE immediately though, perhaps for compatibility with older Bazel. I'll improve the message when merging.

@drigz drigz merged commit ac12a9e into google:master Jan 11, 2024
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants