Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbghelp): show source line number if present #1051

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Jan 8, 2024

Resolves #534

@sergiud sergiud added this to the 0.7 milestone Jan 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c469cc2) 60.00% compared to head (d65d2a4) 60.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
+ Coverage   60.00%   60.03%   +0.03%     
==========================================
  Files          19       19              
  Lines        2580     2580              
  Branches      911      911              
==========================================
+ Hits         1548     1549       +1     
- Misses        692      694       +2     
+ Partials      340      337       -3     
Files Coverage Δ
src/symbolize.cc 54.62% <ø> (ø)

... and 1 file with indirect coverage changes

@sergiud sergiud force-pushed the dbghelp-linenumbers branch 2 times, most recently from 22ffaff to eafd73b Compare January 8, 2024 17:13
@sergiud sergiud force-pushed the dbghelp-linenumbers branch from eafd73b to f07bb63 Compare January 8, 2024 17:20
@sergiud sergiud merged commit 9377254 into master Jan 8, 2024
268 checks passed
@sergiud sergiud deleted the dbghelp-linenumbers branch January 8, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filename / line number to stack traces on Windows.
2 participants