Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce manual resource management #1046

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Jan 7, 2024

No description provided.

@sergiud sergiud added this to the 0.7 milestone Jan 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (1f9ac49) 59.19% compared to head (81e49c9) 59.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
+ Coverage   59.19%   59.55%   +0.36%     
==========================================
  Files          19       19              
  Lines        2551     2564      +13     
  Branches      912      912              
==========================================
+ Hits         1510     1527      +17     
+ Misses        695      692       -3     
+ Partials      346      345       -1     
Files Coverage Δ
src/glog/logging.h 73.23% <ø> (ø)
src/raw_logging.cc 93.44% <100.00%> (ø)
src/utilities.cc 70.58% <100.00%> (ø)
src/utilities.h 100.00% <100.00%> (ø)
src/vlog_is_on.cc 61.71% <100.00%> (ø)
src/symbolize.cc 52.79% <0.00%> (-0.87%) ⬇️
src/windows/dirent.h 32.50% <50.00%> (+0.68%) ⬆️
src/logging.cc 67.29% <63.63%> (+0.02%) ⬆️

@sergiud sergiud force-pushed the no-manual-resources branch from 5094575 to 286696b Compare January 7, 2024 19:23
@sergiud sergiud force-pushed the no-manual-resources branch from 286696b to 81e49c9 Compare January 7, 2024 19:49
@sergiud sergiud merged commit 42a185c into master Jan 7, 2024
268 checks passed
@sergiud sergiud deleted the no-manual-resources branch January 7, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants