Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable strip log tests #1009

Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix: enable strip log tests #1009

merged 1 commit into from
Dec 28, 2023

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Dec 28, 2023

No description provided.

@sergiud sergiud added the bug label Dec 28, 2023
@sergiud sergiud added this to the 0.7 milestone Dec 28, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e92ab7d) 64.25% compared to head (261330f) 65.02%.

Files Patch % Lines
src/logging.cc 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1009      +/-   ##
==========================================
+ Coverage   64.25%   65.02%   +0.76%     
==========================================
  Files          17       17              
  Lines        3321     3322       +1     
  Branches     1123     1121       -2     
==========================================
+ Hits         2134     2160      +26     
+ Misses        760      736      -24     
+ Partials      427      426       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiud sergiud merged commit ab2a1a8 into master Dec 28, 2023
267 of 268 checks passed
@sergiud sergiud deleted the strip-tests branch December 28, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants