Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcbrun trigger #1898

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Fix gcbrun trigger #1898

merged 5 commits into from
Sep 13, 2023

Conversation

DonggeLiu
Copy link
Contributor

Fixes #1897

@DonggeLiu
Copy link
Contributor Author

/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb --fuzzers afl --benchmark libxml2_xml

@DonggeLiu
Copy link
Contributor Author

Testing launching exp with the comment above, will test some other cases once it launches successfully.

@DonggeLiu
Copy link
Contributor Author

Experiment 2023-09-06-fix-gcb data and results will be available later at:
The experiment data.
The experiment report.

@DonggeLiu
Copy link
Contributor Author

/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb --fuzzers afl --benchmark libxml2_xml

This comment should not trigger any experiment now.

@DonggeLiu
Copy link
Contributor Author

DonggeLiu commented Sep 13, 2023

This comment should not trigger any experiment now.

The comment still triggers the GCB, but did not attempt to start an experiment because of this fix. It returns None and prints 'Experiment not requested.'.
This is better than what we had (which attempts to start an experiment), but it is still not optimal because it will intercept the previous experiment request and overwrite the GCB log below)

It would be great if we could simply ignore the GCB command, but that is controlled by GCB trigger, not our script.

@DonggeLiu
Copy link
Contributor Author

/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb-1 --fuzzers afl --benchmark libxml2_xml

@DonggeLiu
Copy link
Contributor Author

Experiment 2023-09-06-fix-gcb-1 data and results will be available later at:
The experiment data.
The experiment report.

@DonggeLiu
Copy link
Contributor Author

/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb-2 --fuzzers afl --benchmark libxml2_xml

@DonggeLiu
Copy link
Contributor Author

Experiment 2023-09-06-fix-gcb-2 data and results will be available later at:
The experiment data.
The experiment report.

@DonggeLiu
Copy link
Contributor Author

/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb-2 --fuzzers afl --benchmark libxml2_xml

@DonggeLiu
Copy link
Contributor Author

/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb-2 --fuzzers afl --benchmark libxml2_xml

@DonggeLiu
Copy link
Contributor Author

/gcbrun run_experiment.py -a --experiment-config /opt/fuzzbench/service/experiment-config.yaml --experiment-name 2023-09-06-fix-gcb-2 --fuzzers afl --benchmark libxml2_xml

This should not start an exp.

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman jonathanmetzman merged commit 9c6a395 into master Sep 13, 2023
5 checks passed
@jonathanmetzman jonathanmetzman deleted the fix_gcbrun_trigger branch September 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only trigger experiments when a comment starts with /gcbrun
2 participants