Fraunces: Version 1.000 added #2755
Conversation
arrowtype
changed the title
|
One small thing I will tweak: the name Otherwise, I do think this is good to go, and should definitely be fine for the sandbox. |
|
Sorry, I got the wrong PR number for the update to sandbox. Do you to do the "tweak" before we review it ? |
Just fixed it, and I’m now re-running the packager. Should be up in 5–10 minutes, pending my internet speed! |
arrowtype
force-pushed
the
gftools_packager_ofl_fraunces
branch
4 times, most recently
from
2b71707 to
37a9d11
Compare
|
Okay, clearly I am doing something wrong with the packager, or I’m just misunderstanding it. Anyway, I updated the variable font files and One question: should the Small update: My git config was giving the commit multiple authors (thundernixon & arrowtype), so I changed it to just one (arrowtype) and re-force-pushed. |
arrowtype
force-pushed
the
gftools_packager_ofl_fraunces
branch
from
37a9d11 to
f253a5b
Compare
Fontbakery reportFontbakery version: 0.7.31 [1] Family checks⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?--- Rationale --- There's no reasonable (and legal) way to run the command `ftxvalidator` of the Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc. If Font Bakery is not running on an OSX machine, the machine running Font Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure call (rpc). There's an ssh example implementation at: https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds /ftxvalidator/ssh-implementation/ftxvalidator
[5] Fraunces-Italic[SOFT,WONK,opsz,wght].ttf⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
⚠ WARN: Are there caret positions declared for every ligature?--- Rationale --- All ligatures in a font must have corresponding caret (text cursor) positions defined in the GDEF table, otherwhise, users may experience issues with caret rendering. If using GlyphsApp, ligature carets can be set directly on canvas by accessing the `Glyph -> Set Anchors` menu option or by pressing the `Cmd+U` keyboard shortcut.
⚠ WARN: Is there kerning info for non-ligated sequences?--- Rationale --- Fonts with ligatures should have kerning on the corresponding non-ligated sequences for text where ligatures aren't used (eg https://github.com/impallari/Raleway/issues/14).
⚠ WARN: Font has **proper** whitespace glyph names?--- Rationale --- This check enforces adherence to recommended whitespace (codepoints 0020 and 00A0) glyph names according to the Adobe Glyph List.
⚠ WARN: Check for points out of bounds.
This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message. [code: points-out-of-bounds] [4] Fraunces[SOFT,WONK,opsz,wght].ttf⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
⚠ WARN: Are there caret positions declared for every ligature?--- Rationale --- All ligatures in a font must have corresponding caret (text cursor) positions defined in the GDEF table, otherwhise, users may experience issues with caret rendering. If using GlyphsApp, ligature carets can be set directly on canvas by accessing the `Glyph -> Set Anchors` menu option or by pressing the `Cmd+U` keyboard shortcut.
⚠ WARN: Is there kerning info for non-ligated sequences?--- Rationale --- Fonts with ligatures should have kerning on the corresponding non-ligated sequences for text where ligatures aren't used (eg https://github.com/impallari/Raleway/issues/14).
⚠ WARN: Font has **proper** whitespace glyph names?--- Rationale --- This check enforces adherence to recommended whitespace (codepoints 0020 and 00A0) glyph names according to the Adobe Glyph List.
Summary
Note: The following loglevels were omitted in this report:
Diff images: qa.zip |
|
Everything looks good, apart from the Axis Value Names do not match the fallback names (without spaces) in our axis registry e.g "SuperSoft" should be "ExtraSoft" |
|
I see you've already posted that our Axis Reg should be improved, #2741. I'll take a look. |
|
Thanks, Marc! I have also added an issue with proposed naming for the |
|
I'm going to keep this open until the axis PRs have been sorted. |
arrowtype
force-pushed
the
gftools_packager_ofl_fraunces
branch
from
f253a5b to
c00277d
Compare
|
Updates:
But, now that I look at the files, I see that this is lacking the description HTML, metadata pb, and OFL. I will revert to using a shell script for these updates, as I am somehow mis-using the packager. Another update coming shortly... |
Fontbakery reportFontbakery version: 0.7.31 [1] Family checks⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?--- Rationale --- There's no reasonable (and legal) way to run the command `ftxvalidator` of the Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc. If Font Bakery is not running on an OSX machine, the machine running Font Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure call (rpc). There's an ssh example implementation at: https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds /ftxvalidator/ssh-implementation/ftxvalidator
[5] Fraunces-Italic[SOFT,WONK,opsz,wght].ttf⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak.--- Rationale --- Some older text-handling tools sometimes misbehave if the last line of data in a text file is not terminated with a newline character (also known as '\n'). We know that this is a very small detail, but for the sake of keeping all DESCRIPTION.en_us.html files uniformly formatted throughout the GFonts collection, we chose to adopt the practice of placing this final linebreak char on them.
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
⚠ WARN: Are there caret positions declared for every ligature?--- Rationale --- All ligatures in a font must have corresponding caret (text cursor) positions defined in the GDEF table, otherwhise, users may experience issues with caret rendering. If using GlyphsApp, ligature carets can be set directly on canvas by accessing the `Glyph -> Set Anchors` menu option or by pressing the `Cmd+U` keyboard shortcut.
⚠ WARN: Font has **proper** whitespace glyph names?--- Rationale --- This check enforces adherence to recommended whitespace (codepoints 0020 and 00A0) glyph names according to the Adobe Glyph List.
⚠ WARN: Does GPOS table have kerning information?
[7] Fraunces[SOFT,WONK,opsz,wght].ttf⚠ WARN: DESCRIPTION.en_us.html should end in a linebreak.--- Rationale --- Some older text-handling tools sometimes misbehave if the last line of data in a text file is not terminated with a newline character (also known as '\n'). We know that this is a very small detail, but for the sake of keeping all DESCRIPTION.en_us.html files uniformly formatted throughout the GFonts collection, we chose to adopt the practice of placing this final linebreak char on them.
⚠ WARN: METADATA.pb: Fontfamily is listed on Google Fonts API?
⚠ WARN: Are there caret positions declared for every ligature?--- Rationale --- All ligatures in a font must have corresponding caret (text cursor) positions defined in the GDEF table, otherwhise, users may experience issues with caret rendering. If using GlyphsApp, ligature carets can be set directly on canvas by accessing the `Glyph -> Set Anchors` menu option or by pressing the `Cmd+U` keyboard shortcut.
⚠ WARN: Is there kerning info for non-ligated sequences?--- Rationale --- Fonts with ligatures should have kerning on the corresponding non-ligated sequences for text where ligatures aren't used (eg https://github.com/impallari/Raleway/issues/14).
⚠ WARN: Combined length of family and style must not exceed 27 characters.--- Rationale --- According to a GlyphsApp tutorial [1], in order to make sure all versions of Windows recognize it as a valid font file, we must make sure that the concatenated length of the familyname (NameID.FONT_FAMILY_NAME) and style (NameID.FONT_SUBFAMILY_NAME) strings in the name table do not exceed 20 characters. After discussing the problem in more detail at `FontBakery issue #2179 [2] we decided that allowing up to 27 chars would still be on the safe side, though. [1] https://glyphsapp.com/tutorials/multiple-masters-part-3-setting-up-instances [2] https://github.com/googlefonts/fontbakery/issues/2179
Please take a look at the conversation at fonttools/fontbakery#2179 in order to understand the reasoning behind these name table records max-length criteria. [code: too-long] ⚠ WARN: Font has **proper** whitespace glyph names?--- Rationale --- This check enforces adherence to recommended whitespace (codepoints 0020 and 00A0) glyph names according to the Adobe Glyph List.
⚠ WARN: The variable font 'opsz' (Optical Size) axis coordinate should be between 9 and 13 on the 'Regular' instance.--- Rationale --- According to the Open-Type spec's registered design-variation tag 'opsz' available at https://docs.microsoft.com/en-gb/typography/opentype/spec/dvaraxistag_opsz If a variable font has a 'opsz' (Optical Size) axis, then the coordinate of its 'Regular' instance is recommended to be a value in the range 9 to 13.
Summary
Note: The following loglevels were omitted in this report:
Diff images: qa.zip |
|
Closing in favor of #2776, which uses a shell script I am more familiar with than the gftools packager, and which includes the files which are missing here. |
[partially a manual push due to issue in packager]
This is Fraunces after some mastering work.
It includes two variable fonts:
...and 108 static fonts, 6 weights w/ Roman & Italics in the following families:
It is possible/likely that a couple of style names may still need to be adjusted, pending agreement from @davelab6 & @sponcey:
SOFT(Softness) Axis might be better named with alphabetic styles: Proposal: update stylenames for SOFT axis to sort alphabetically #2760WONK(Wonky) axis should have the name "Wonky," the default of "Wonky" (elided) at0and a style of "NonWonky" at0: Proposal: “Wonkiness” axis name should be “Wonky” due to its binary usage; "Normal" name should be "NonWonky" #2741opszdefaults to9unless we want to get clever and add 72pt sources (this would perhaps better live up to the spirit of the family as a display face, but would add scope & complexity to build, plus some filesize to the VFs)I anticipate that there are a couple of FontBakery issues, but I am partially checking what the automated PR tests are like these days. Thanks!