[C++] Align serialized scalars by wire size#9184
Open
carrerasdarren-cell wants to merge 1 commit into
Open
Conversation
Use scalar widths for vector and length-prefix wire alignment while preserving compiler alignment for generated structs. This prevents host ABI alignment rules from inserting padding into serialized buffers. Add portable regression coverage with deliberately under-aligned scalar types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9182.
FlatBuffers aligns serialized scalars to their size, but several templated
builder paths used the host compiler's ABI alignment instead. On targets such
as m68k, where
uint32_tis 4 bytes with 2-byte ABI alignment, this can makePushElementinsert padding between a string's length prefix and payload.Scalar and offset vectors have the same wire-alignment mismatch.
This change:
Offset, andOffset64vector elements whileretaining
AlignOf<T>()for generated structs;32-bit and 64-bit scalar types.
Validation:
flattests: all tests passed.qemu-m68k: stock masterinserts two zero bytes and fails; patched code emits the canonical bytes and
passes.