[Python] Fix FlexBuffers typed vector float conversion#9181
Open
winklemad wants to merge 1 commit into
Open
Conversation
Treat typed-vector predicates as properties when converting references to float, and use the fixed typed-vector accessor for fixed vectors. Add coverage through the public builder and parser APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref.AsFloatfor typed and fixed typed vectors by treating their type checks as properties.AsFixedTypedVectorwhen reading fixed typed-vector length.Builder,Finish, andGetRootAPIs.Problem
IsTypedVectorandIsFixedTypedVectorare properties, butAsFloatcalled them as functions. Valid typed vectors therefore raisedTypeError. The fixed-vector branch also referenced the nonexistentFixedTypedVectoraccessor.Testing
PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=python python3 -m unittest tests.py_flexbuffers_test.DecoderTest.test_typed_vectors_as_floatPYTHONDONTWRITEBYTECODE=1 PYTHONPATH=../python python3 py_flexbuffers_test.pypy_test.py— 127 tests passed each.git diff --checkThe wrapper suites
tests/PythonTest.shandtests/TestAll.sh, which require CMake and a builtflatcfor their Python stage, were not run locally. The relevant Python runtime suites were run directly.