Skip to content

Conversation

@auschi-shieldai
Copy link

@auschi-shieldai auschi-shieldai commented Dec 22, 2025

This PR fixes two issues:

  • Resolves an issue where relative import paths are not generated correctly for dependents with no namespace
  • Refactors how relative imports are generated, removing the need to back out multiple, unnecessary directory levels
image

A new test suite has been added to validate relative import paths, as well as the fix itself.

This PR also sneaks a couple linting/formatting fixes in for unrelated parts of the idl_gen_ts.cp file.

@google-cla
Copy link

google-cla bot commented Dec 22, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@bjornharrtell bjornharrtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jtdavis777 jtdavis777 added the ready-for-merge This PR has been approved by a maintainer and is ready for merge by a code owner label Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ codegen Involving generating code from schema javascript json python ready-for-merge This PR has been approved by a maintainer and is ready for merge by a code owner typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants