Skip to content

Revert "fix using null string in vector (#7872)" #8879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtdavis777 wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −7
Open

Revert "fix using null string in vector (#7872)" #8879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f4b730
Revert "fix using null string in vector (#7872)"
jtdavis777 Dec 22, 2025
288812a
Merge branch 'master' into fix/revert_7872
jtdavis777 Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions net/FlatBuffers/FlatBufferBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,7 @@ public void AddOffset(int off)
if (off > Offset)
throw new ArgumentException();

if (off != 0)
off = Offset - off + sizeof(int);
off = Offset - off + sizeof(int);
PutInt(off);
}

Expand Down
6 changes: 1 addition & 5 deletions net/FlatBuffers/Table.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,7 @@ public static int __indirect(int offset, ByteBuffer bb)
// Create a .NET String from UTF-8 data stored inside the flatbuffer.
public string __string(int offset)
{
int stringOffset = bb.GetInt(offset);
if (stringOffset == 0)
return null;

offset += stringOffset;
offset += bb.GetInt(offset);
var len = bb.GetInt(offset);
var startPos = offset + sizeof(int);
return bb.GetStringUTF8(startPos, len);
Expand Down
Loading