[Rust] Add ENUM_VALUES generation for bit_flags enums #8835
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@aardappel Hello, could you spare some time to review this PR? Thank you very much! |
aardappel
approved these changes
Dec 7, 2025
Collaborator
|
what's a typical use case for this? |
Collaborator
|
would love to see a new test that showcases this feature <3 |
Author
|
@jtdavis777 That's a great idea! I will add a test case to demonstrate this feature. |
Collaborator
|
hey @wentywenty just checking in on that test case :) |
Contributor
|
@wentywenty Hello. do u need some help for this? |
jtdavis777
added
the
waiting-for-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the generation of the ENUM_VALUES constant array for enums marked with the bit_flags attribute in Rust.
Motivation: Currently, standard enums generate an ENUM_VALUES array, but bit_flags enums do not. This makes it difficult to iterate over all defined base flag values (e.g., for UI lists, serialization helpers, or debugging).
Changes: Modified src/idl_gen_rust.cpp to generate an impl block containing ENUM_VALUES for bitflags, mirroring the behavior of standard enums.