dart: Ensure fields are only written once #8455
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone with a protobuf background might assume that vector object fields are written by calling `.addFoo()` in a loop. However this results in a silently corrupted message since the vector isn't serialized as expected. This patch adds a debug assertion to ensure fields are only written once to catch this type of error. The assertion uncovered a bug in the library where struct fields are needlessly added twice, which we also fix.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone with a protobuf background might assume that vector object fields are
written by calling
.addFoo()in a loop. However this results in a silentlycorrupted message since the vector isn't serialized as expected.
This patch adds a debug assertion to ensure fields are only written once to
catch this type of error.
The assertion uncovered a bug in the library where struct fields are needlessly
added twice, which we also fix.