Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Fix function name for Pack method for structs #8427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kojung
Copy link

@kojung kojung commented Oct 13, 2024

This PR fixes #8422 .

Before we get this:

class ABCWordT(object):
    # ABCWordT
    def Pack(self, builder):
        return CreateAbcword(builder, self.w)

Where the function CreateAbcword does not exist.

After we get this:

class ABCWordT(object):
    # ABCWordT
    def Pack(self, builder):
        return CreateABCWord(builder, self.w)

And the function CreateABCWord does exist.

Copy link

google-cla bot commented Oct 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added c++ codegen Involving generating code from schema python labels Oct 13, 2024
@kojung kojung force-pushed the python-fix-object-api-name branch from b282b93 to 90c5472 Compare October 13, 2024 06:43
@kojung kojung changed the title Fix function name for Pack method for structs [Python] Fix function name for Pack method for structs Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] Object API has the wrong name
1 participant