Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Depends on #8379] Add webview for fgviewer #8428

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

[Depends on #8379] Add webview for fgviewer #8428

wants to merge 47 commits into from
+933 −24

Conversation

show50726
Copy link
Contributor

NOTE: This PR should be merged after #8379 is in.

The initial version of fgviewer webpage:
image
Feel free to comment on my css/js usage since I'm new to web dev.

Ongoing works:

  • Distinguish "sample texture" and "read texture"
  • There are some nodes with different ids but in fact pointing to a same resource, try to merge them into one

@show50726
Introduce FrameGraphInfo class
5ec4de6
@show50726
Move the assignment into pimpl
6eb7196
@show50726
Make ctors explicit
04afaa9
@show50726
Add ctors to fg info structs
1cd1d70
@show50726
Revert the macro change to align with existing
e59b111
@show50726
Address the comments
c02d231
@show50726
Merge branch 'main' into dev/framegraph-info
41ee934
@show50726
Merge branch 'main' into dev/framegraph-info
077e841
@show50726
Remove pimpl and move func def to .cc
e6a3af6
@show50726
Fix
a7f8176
@show50726
Convert the FrameGraph to FrameGraphInfo
1b41bf8
@show50726
Initialize and update debug server on engine side
ccc4f8a
@show50726
Merge branch 'main' into dev/fginfo-conversion
802531c 
# Conflicts:
#	libs/fgviewer/include/fgviewer/DebugServer.h
#	libs/fgviewer/include/fgviewer/FrameGraphInfo.h
#	libs/fgviewer/src/FrameGraphInfo.cpp
@show50726
Fix compile error
4618bf5
@show50726
Address the comments
0429512
@show50726
Update
cfafbaf
@show50726
Use camelCase
262f594
@show50726
Use camelCase
91dc91e
@show50726
Update
f05400c
@show50726
Add JsonWriter to convert fginfo to json
6dcfbb7
@show50726
Add getStatus api and implement it
96a4675
@show50726
Add increment
482a7f1
@show50726
Implement GET apis
1ccf6b5
@show50726
Fix compile error
17aa06c
@show50726
Update
4fe894c
@show50726
Use c_str_safe
14ea247
@show50726
Merge branch 'main' into dev/api-handling
afb9987 
# Conflicts:
#	filament/src/details/Engine.cpp
@show50726
Add operator== for FrameGraphInfo
57502a4
@show50726
Call updateFrameGraph in appropriate locations
0e4cfc2
@show50726
Address the comments
8715fc5
@show50726 show50726 added the internal Issue/PR does not affect clients label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixelflinger pixelflinger Awaiting requested review from pixelflinger

@bejado bejado Awaiting requested review from bejado

@poweifeng poweifeng Awaiting requested review from poweifeng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@show50726