Fix __qualname__ AttributeError in fiddle config.py#603
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 2, 2026
Merged
Fix __qualname__ AttributeError in fiddle config.py#603copybara-service[bot] merged 1 commit intomainfrom
__qualname__ AttributeError in fiddle config.py#603copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_893119387
branch
6 times, most recently
from
75479c2 to
908daa2
Compare
If a partial function generated by `functools.partial` is passed into fiddle AND certain exceptions are raised, accessing `__qualname__` will trigger another exception, prevent the users from seeing the real error messages. Type type `TypeOrCallableProducingT = Union[Callable[..., T], Type[T]]` does not guarantee that `__qualname__` will exist. - Added a regression test case in third_party/py/fiddle/_src/config_test.py that uses functools.partial to trigger the bug. - Replace all `self.__fn_or_cls__.__qualname__` with the existing `self._fn_or_cls_name_repr()` which already solved the problem. PiperOrigin-RevId: 893707305
copybara-service
bot
force-pushed
the
test_893119387
branch
from
908daa2 to
5502465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
__qualname__AttributeError in fiddle config.pyIf a partial function generated by
functools.partialis passed intofiddle AND certain exceptions are raised, accessing
__qualname__will trigger another exception, prevent the users from seeing the
real error messages.
Type type
TypeOrCallableProducingT = Union[Callable[..., T], Type[T]]does not guarantee that
__qualname__will exist.self.__fn_or_cls__.__qualname__with the existingself._fn_or_cls_name_repr()which already solved the problem.