Update some tests for var position handling to pass on JDK 26#5665
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 25, 2026
Merged
Update some tests for var position handling to pass on JDK 26#5665copybara-service[bot] merged 1 commit intomasterfrom
var position handling to pass on JDK 26#5665copybara-service[bot] merged 1 commit intomasterfrom
Conversation
I think these are affected by https://bugs.openjdk.org/browse/JDK-8359383 These tests cover crash handling on earlier versions, on JDK 26 `var` start and end positions are the same so trying to replace `var` will result in adding the replacement as a prefix. In practice checks need to be using `hasExplicitSource` and `replaceVariableType` to handle `var` prior to JDK 27. PiperOrigin-RevId: 889460016
copybara-service
bot
force-pushed
the
test_889128089
branch
from
71d61f9 to
4f91e96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update some tests for
varposition handling to pass on JDK 26I think these are affected by https://bugs.openjdk.org/browse/JDK-8359383
These tests cover crash handling on earlier versions, on JDK 26
varstart and end positions are the same so trying to replacevarwill result in adding the replacement as a prefix. In practice checks need to be usinghasExplicitSourceandreplaceVariableTypeto handlevarprior to JDK 27.