Dll loading VST3 #88
Dll loading VST3 #88
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
BrandenAvalonCx
left a comment
BrandenAvalonCx
left a comment
There was a problem hiding this comment.
Seems like the right approach to solve our DLL issue.
A few cleanup things here, and the commit author needs to be fixed, but then should be good to go
| endif() | ||
| endif() | ||
|
|
||
| if (WIN32 AND NOT DELAYLOAD_HEADER_GENERATED_RDR) |
There was a problem hiding this comment.
All this code to generate the header can be removed since the header file isn't used anymore
There was a problem hiding this comment.
Not sure why this PR updates the obr.dll and .dylib
There was a problem hiding this comment.
We should drop this file
2 participants
Description
Added runtime DLL loading for VST3 on Windows (fixes Reaper compatibility)
Validation and Acceptance Criteria