Improve Player File Callback Handling #83
Conversation
| browseVideoButton_.setEnabled(true); | ||
| browseVideoSourceButton_.setEnabled(true); | ||
| if (!config.getExportCompleted()) { |
There was a problem hiding this comment.
I removed this to be consistent with how we update the exportCompleted field. I didn't write this so I'm unsure if this a problem for any DAWs @BrandenAvalonCx?
There was a problem hiding this comment.
This is specifically needed for Premiere Pro. It looks like this change may be fine, but it should be tested on Premiere Pro to verify that it's okay to just update to true without checking the exportCompleted flag has been set.
BrandenAvalonCx
left a comment
BrandenAvalonCx
left a comment
There was a problem hiding this comment.
Testing shows this doesn't resolve the issue on windows. Not sure if we should still apply this fix or if you want to further investigate after the release
|
|
||
| if (kFileToLoad.empty() || kFileToLoad.extension() != ".iamf" || | ||
| !std::filesystem::exists(kFileToLoad)) { | ||
| // If the file doesn't exist or it's a new file, we set the player to a |
There was a problem hiding this comment.
I don't understand how this is checking for a "new" file. Do you mean an empty file?
There was a problem hiding this comment.
If the path to the given output file does not exist, export must be to a new file not rewriting an existing file.
How would an empty iamf file exist here besides maybe a crash during export?
| browseVideoButton_.setEnabled(true); | ||
| browseVideoSourceButton_.setEnabled(true); | ||
| if (!config.getExportCompleted()) { |
There was a problem hiding this comment.
This is specifically needed for Premiere Pro. It looks like this change may be fine, but it should be tested on Premiere Pro to verify that it's okay to just update to true without checking the exportCompleted flag has been set.
2 participants
Description
On Windows the player was crashing when export is to the same file as the selected file for the player. We add better checking in
AudioFilePlayercallbacks for the start and stop of export, and destroy the existing player at the start of export.Changes
IAMFPlaybackDevicecould be created on export start instead of finish.Validation and Acceptance Criteria
Validated manually via UI