-
Notifications
You must be signed in to change notification settings - Fork 10
add ci for windows #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
2bef397 to
17a9aca
Compare
joelmacx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There's merit at some point in putting the larger more complex steps in their own files. As the pipeline is simple this system is fine for now.
Thanks for the feedback. Agreed on keeping it simple for now and extract the complex steps into separate scripts in a future PR. |
joelmacx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
This PR adds GitHub Actions CI workflows to build and test the Eclipsa audio plugin on both Windows and macOS platforms. This ensures that pull requests don't break platform compatibility and provides automated validation before merging to main.
Changes
CI Workflow
Added cmake-multi-platform.yml for Windows (windows-latest) and macOS (macos-14) builds
Added Git LFS support to properly checkout binary dependencies
Validation and Acceptance Criteria
Briefly describe how this PR meets any acceptance criteria defined in the linked issue.