Skip to content

Conversation

@PraveenAcx
Copy link
Collaborator

@PraveenAcx PraveenAcx commented Dec 4, 2025

Description

This PR adds GitHub Actions CI workflows to build and test the Eclipsa audio plugin on both Windows and macOS platforms. This ensures that pull requests don't break platform compatibility and provides automated validation before merging to main.

Changes

CI Workflow
Added cmake-multi-platform.yml for Windows (windows-latest) and macOS (macos-14) builds
Added Git LFS support to properly checkout binary dependencies

Validation and Acceptance Criteria

Briefly describe how this PR meets any acceptance criteria defined in the linked issue.

  • macOS builds complete successfully on GitHub Actions runners
  • Windows builds complete successfully on GitHub Actions runners

@google-cla
Copy link

google-cla bot commented Dec 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@PraveenAcx PraveenAcx force-pushed the ci-windows-macos-support branch from 2bef397 to 17a9aca Compare December 5, 2025 14:36
Copy link
Collaborator

@joelmacx joelmacx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There's merit at some point in putting the larger more complex steps in their own files. As the pipeline is simple this system is fine for now.

@PraveenAcx
Copy link
Collaborator Author

Looks good. There's merit at some point in putting the larger more complex steps in their own files. As the pipeline is simple this system is fine for now.

Thanks for the feedback. Agreed on keeping it simple for now and extract the complex steps into separate scripts in a future PR.

Copy link
Collaborator

@joelmacx joelmacx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joelmacx joelmacx merged commit 8ccf1c5 into main Dec 8, 2025
3 checks passed
@joelmacx joelmacx deleted the ci-windows-macos-support branch December 8, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants