No public description

PiperOrigin-RevId: 636374813
google · May 23, 2024 · c1a78df · c1a78df
1 parent 9aca55e
commit c1a78df
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 11 deletions.
diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml
@@ -7,10 +7,12 @@ on: [
 
 jobs:
   build:
-    name: "python ${{ matrix.python-version }} tests"
-    runs-on: ubuntu-latest
+    name: "Python ${{ matrix.python-version }} tests on ${{ matrix.os }}"
+    runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
+        os: [ubuntu-latest]
         python-version: [
             "3.7",
             "3.8",
@@ -19,6 +21,11 @@ jobs:
             "3.11",
             "3.12",
         ]
+        include:
+          - os: macos-latest
+            python-version: "3.11"
+          - os: windows-latest
+            python-version: "3.11"
     steps:
       - uses: actions/checkout@v3
       - name: Set up Python

diff --git a/javascript/src/data.js b/javascript/src/data.js
@@ -795,13 +795,14 @@ ee.data.makeThumbUrl = function(id) {
  * @param {!Object} params An object containing download options with the
  *     following possible values:
  *   <table>
- *     <tr>
+  *     <tr>
  *       <td><code> name: </code> a base name to use when constructing
- *         filenames. Only applicable when format is "ZIPPED_GEO_TIFF" (default)
- *         or filePerBand is true. Defaults to the image id (or "download" for
- *         computed images) when format is "ZIPPED_GEO_TIFF" or filePerBand is
- *         true, otherwise a random character string is generated. Band names
- *         are appended when filePerBand is true.</td>
+ *         filenames. Only applicable when format is "ZIPPED_GEO_TIFF"
+ *         (default), "ZIPPED_GEO_TIFF_PER_BAND", or filePerBand is true.
+ *         Defaults to the image id (or "download" for computed images) when
+ *         format is "ZIPPED_GEO_TIFF", "ZIPPED_GEO_TIFF_PER_BAND", or
+ *         filePerBand is true, otherwise a random character string is
+ *         generated. Band names are appended when filePerBand is true.</td>
  *     </tr>
  *     <tr>
  *       <td><code> bands: </code> a description of the bands to download. Must
@@ -847,14 +848,17 @@ ee.data.makeThumbUrl = function(id) {
  *     <tr>
  *       <td><code> filePerBand: </code> whether to produce a separate GeoTIFF
  *         per band (boolean). Defaults to true. If false, a single GeoTIFF is
- *         produced and all band-level transformations will be ignored.</td>
+ *         produced and all band-level transformations will be ignored.  Note
+ *         that this is ignored if the format is "ZIPPED_GEO_TIFF" or
+ *          "ZIPPED_GEO_TIFF_PER_BAND".</td>
  *     </tr>
  *     <tr>
  *       <td><code> format: </code> the download format. One of:
  *         <ul>
- *           <li> "ZIPPED_GEO_TIFF" (GeoTIFF file(s) wrapped in a zip file,
+ *           <li> "ZIPPED_GEO_TIFF" (GeoTIFF file wrapped in a zip file,
  *             default)</li>
- *           <li> "GEO_TIFF" (GeoTIFF file)</li>
+ *           <li> "ZIPPED_GEO_TIFF_PER_BAND" (Multiple GeoTIFF files wrapped
+ *             in a zip file)</li>
  *           <li> "NPY" (NumPy binary format)</li>
  *         </ul>
  *         If "GEO_TIFF" or "NPY", filePerBand and all band-level