Switch from floryn90/hugo to hugomods/hugo image #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianladisch
force-pushed
the
hugomods
branch
from
384fb70 to
8ab1007
Compare
There was a problem hiding this comment.
Pull Request Overview
Switches the Docker configuration from a custom-built image using floryn90/hugo to the hugomods/hugo:std-exts image to resolve permission issues. This change eliminates the need for a custom Dockerfile since the new image includes all required dependencies.
- Replaced custom Docker build with hugomods/hugo:std-exts image
- Simplified docker-compose configuration and documentation
- Removed obsolete Dockerfile
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docker-compose.yaml | Updated to use hugomods/hugo:std-exts image directly, added cache volume mount |
| README.md | Simplified Docker setup instructions by removing build step |
| Dockerfile | Removed entirely as it's no longer needed |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
@deining - any comment? |
julianladisch
force-pushed
the
hugomods
branch
from
fd36963 to
fd88506
Compare
The site build fails since floryn90/hugo v0.134.3: ``` Error: error building site: failed to acquire a build lock: open /src/.hugo_build.lock: permission denied ``` Cause: The Alpine image has switched from root user to hugo user: floryn90/docker-hugo@b261630 Fix: Switch to hugomods/hugo image that still runs as root user. The hugomods/hugo:std-exts image has git included making our Dockerfile obsolete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site build using docker-compose fails since floryn90/hugo v0.134.3:
Cause: The Alpine image has switched from root user to hugo user:
floryn90/docker-hugo@b261630
Fix: Switch to hugomods/hugo image that still runs as root user.
The hugomods/hugo:std-exts image has git included making our Dockerfile obsolete.
Documentation: https://docker.hugomods.com/docs/development/docker-compose/