Add vcpkg installation instructions #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
toor1245
reviewed
Sep 1, 2022
toor1245
approved these changes
Sep 6, 2022
gchatelet
reviewed
Sep 19, 2022
| ./vcpkg install cpu-features | ||
| ``` | ||
|
|
||
| The cpu_features port in vcpkg is kept up to date by Microsoft team members and community contributors. If the version is out of date, please [create an issue or pull request](https://github.com/Microsoft/vcpkg) on the vcpkg repository. |
There was a problem hiding this comment.
trim supplementary spaces between "pull" and "request"
gchatelet
reviewed
Sep 19, 2022
| ./vcpkg install cpu-features | ||
| ``` | ||
|
|
||
| The cpu_features port in vcpkg is kept up to date by Microsoft team members and community contributors. If the version is out of date, please [create an issue or pull request](https://github.com/Microsoft/vcpkg) on the vcpkg repository. |
There was a problem hiding this comment.
Cite cpu_features (and vcpkg) by using back quotes, here an above
gchatelet
reviewed
Sep 19, 2022
| @@ -250,6 +250,19 @@ Please check the [CMake build instructions](cmake/README.md). | |||
| cmake --build build --config Release --target install -v -- DESTDIR=install | |||
| ``` | |||
|
|
|||
| - Installing cpu_features(vcpkg) | |||
There was a problem hiding this comment.
space after cpu_features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpu_featuresavailable as a port in vcpkg, a C++ library manager that simplifies installation forcpu_featuresand other project dependencies. Documenting the install process here will help users get started by providing a single set of commands to build cpu_features, ready to be included in their projects.We also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64) to keep a wide coverage for users.
I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library.