Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copybara: adding a modifiable base url #316

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohamedsaidbmw
Copy link

@mohamedsaidbmw mohamedsaidbmw commented Mar 2, 2025

in order to sync enterprise internal repos with the open source repos we need to get rid of the hardcoded github.com and make it a variable that can be modified via cmd-line

Copy link

google-cla bot commented Mar 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mohamedsaidbmw mohamedsaidbmw force-pushed the ms_add_modifiable_base_url branch 2 times, most recently from cc47c2e to 6db01a3 Compare March 2, 2025 21:39
@mohamedsaidbmw mohamedsaidbmw changed the base branch from main to master March 3, 2025 08:56
@mohamedsaidbmw mohamedsaidbmw force-pushed the ms_add_modifiable_base_url branch 4 times, most recently from 3901ff3 to 6d44220 Compare March 3, 2025 10:06
in order to sync enterprise internal repos
with the open source repos we need to get rid of the hardcoded
github.com and make it a variable that can be modified via cmd-line
and BaseUrlConfig.
@mohamedsaidbmw mohamedsaidbmw force-pushed the ms_add_modifiable_base_url branch from 6d44220 to 19068c9 Compare March 3, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant