Update CI config. #1235
Merged
Update CI config. #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis and lgtm.com configs are obsolete. For Github actions use latest Android cmdline tools and add Java 21 to the test matrix.
Breaks ubuntu build due to being compiled for a later Java.
Some of these will need reworking later. Also simplify YAML for matrix testing, and add macos-13 which should give coverage on x86 as well as ARM.
Gets rid of much log spam when testing.
Also include 2 distributions. Temurin is pretty close to pure OpenJDK and Azul Zulu have their own fixes.
Yqwed
reviewed
Oct 13, 2024
Yqwed
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis and lgtm.com configs are obsolete.
For Github actions use latest action versions, and add Java 17 and 21 to the test matrix as well as more than one distribution.
Skip some tests on Java 17 and 21 which need further work to run on those platforms, some of which will go away along with the fd socket. Note we worked around these internally with add-opens to bypass reflection restrictions, but that won't cut it here.
Not being able to get the original hostname for InetAddresses without reverse DNS might be a real problem for hostname verification down the line.....
Sorry for the bazillion commits, but overall this puts our CI in a better place. Will probably rejig the test matrix some more so we catch issues early on very new Java versions, and to reduce the number of combos where we test against two Java distributions.