Add try-except to google groups call in access lib#5212
Open
ViniciustCosta wants to merge 1 commit intomasterfrom
Open
Add try-except to google groups call in access lib#5212ViniciustCosta wants to merge 1 commit intomasterfrom
ViniciustCosta wants to merge 1 commit intomasterfrom
Conversation
Collaborator
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSS-fuzz and internal users reported similar issues related to uncaught exception being leaked and displayed on the UI when trying to access clusterfuzz pages. The error itself is intermittent and not really a CF bug, but we obviously shouldn't be displaying the exception message.
For some case, there are references to the google groups api recently added. This adds a try-except block to the cloud group identity api call that is done to check for membership in the privileged groups during the access module.