Add Swarming service for Remote Task Gate#5206
Open
jardondiego wants to merge 17 commits intomasterfrom
Open
Conversation
6adf5ef to
241f5b6
Compare
jardondiego
commented
Mar 13, 2026
jardondiego
commented
Mar 13, 2026
jardondiego
commented
Mar 13, 2026
jardondiego
commented
Mar 13, 2026
jardondiego
commented
Mar 13, 2026
0033ed9 to
a54d1d5
Compare
017887b to
9702d8d
Compare
jardondiego
commented
Mar 18, 2026
jardondiego
commented
Mar 18, 2026
9702d8d to
7200eda
Compare
jardondiego
commented
Mar 18, 2026
9da970f to
615788e
Compare
85786d5 to
5b1690f
Compare
jardondiego
commented
Mar 19, 2026
jardondiego
commented
Mar 19, 2026
Co-authored-by: Diego Jardon <37823380+jardondiego@users.noreply.github.com>
IvanBM18
reviewed
Mar 19, 2026
2917cf7 to
b79d077
Compare
45274e8 to
150e132
Compare
Collaborator
javanlacerda
left a comment
There was a problem hiding this comment.
Overall looks good, and I think we can merge it once some minor fixes are addressed, and then we can make the other adjustments in the following PRs.
We just need to be sure that the changes will not have any side effect in prod.
| if len(remote_tasks) == 1: | ||
| unscheduled_tasks = [] | ||
|
|
||
| if feature_flags.FeatureFlags.SWARMING_REMOTE_EXECUTION.enabled: |
Collaborator
There was a problem hiding this comment.
I think we could keep this function cleaner if we could move this logic to an auxiliary function.
Collaborator
Author
There was a problem hiding this comment.
I am not sure I see an auxiliary function with this single line. I guess I probably do not understand very well what would we encapsulate in that auxiliary function. Can you clarify?
c78524e to
78a1502
Compare
78a1502 to
d4e44d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add remote task service for Swarming and include it in Remote Task gate logic.
Summary
This PR integrates Swarming as a first-class remote task execution service within the RemoteTaskGate. It introduces the SwarmingService, which encapsulates the logic for pushing uworker main tasks to Swarming, and updates the
RemoteTaskGate to utilize this service for unified task distribution.
Key Changes
swarming.push_swarming_task, providing a standardized interface consistent with Kubernetes and GCP Batch services.
filter and process swarming-eligible tasks and return the remaining tasks for distribution to other backends.