Implement read of 3D images with unnormalised sampler #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjodinchr
added a commit
to rjodinchr/clvk
that referenced
this pull request
Sep 20, 2023
This PR depends on google/clspv#1234 We parse the new NormalizedSamplerMaskPushConstant non-semantic instruction from KhronosGroup/SPIRV-Headers#377. Set the sampler mask in the push constant, but also create a new sampler with normalised coordinate if not already the case or already created.
rjodinchr
added a commit
to rjodinchr/clvk
that referenced
this pull request
Sep 20, 2023
This PR depends on google/clspv#1234 We parse the new NormalizedSamplerMaskPushConstant non-semantic instruction from KhronosGroup/SPIRV-Headers#377. Set the sampler mask in the push constant, but also create a new sampler with normalised coordinate if not already the case or already created.
rjodinchr
added a commit
to rjodinchr/clvk
that referenced
this pull request
Sep 20, 2023
This PR depends on google/clspv#1234 We parse the new NormalizedSamplerMaskPushConstant non-semantic instruction from KhronosGroup/SPIRV-Headers#377. Set the sampler mask in the push constant, but also create a new sampler with normalised coordinate if not already the case or already created.
rjodinchr
added a commit
to rjodinchr/clvk
that referenced
this pull request
Sep 20, 2023
This PR depends on google/clspv#1234 We parse the new NormalizedSamplerMaskPushConstant non-semantic instruction from KhronosGroup/SPIRV-Headers#377. Set the sampler mask in the push constant, but also create a new sampler with normalised coordinate if not already the case or already created.
rjodinchr
force-pushed
the
pr/sampler-arg
branch
from
c2160a2 to
8574223
Compare
|
Ref #1202 |
alan-baker
reviewed
Sep 20, 2023
|
Please rebase this on top of the headers, I've merged the necessary changes. |
We need to know where the sampler is coming from, so we need to inline every function containing a read image of a 3d image with non literal sampler. This PR depends on KhronosGroup/SPIRV-Headers#377 We use the information from the sampler mask to know if you need to use the original coordinates or the one we have normalised. Like for channel_image_order and channel_image_data_type we use metadata to pass information through the pipeline.
rjodinchr
force-pushed
the
pr/sampler-arg
branch
from
73f3313 to
dba366e
Compare
|
Amber does not have the new spirv-headers yet. |
alan-baker
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to know where the sampler is coming from, so we need to inline every function containing a read image of a 3d image with non literal sampler.
This PR depends on KhronosGroup/SPIRV-Headers#377
We use the information from the sampler mask to know if you need to use the original coordinates or the one we have normalised.
Like for channel_image_order and channel_image_data_type we use metadata to pass information through the pipeline.