Update strings.format to adhere to the specification #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
Signed-off-by: Justin King <[email protected]>
| return formatStringV2(arg) | ||
| } | ||
|
|
||
| func (c *stringFormatterV2) Decimal(arg ref.Val) (string, error) { |
There was a problem hiding this comment.
Could you propagate the comments from the v1 file into v2?
There was a problem hiding this comment.
Which ones? I thought I copy pasted pretty much everything?
There was a problem hiding this comment.
Oh, just the capitalized methods. They're all exposed, so golint will complain if they're not commented.
There was a problem hiding this comment.
I thought it only did that for public types? Because formatting.go does have them commented either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.