feat: Edit option in block context menu #274
Open
+136
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the main directional shortcuts to match the names of corresponding keys. Not renaming the corresponding methods on LineCursor yet as that seems like a riskier change.
If there are no inline nodes to the right of the cursor on the
'current line' of the program, hide the Edit option.
This means the menu item is shown any time the cursor is on a
block and not in the rightmost position 'on the current line';
consequently sometimes the description ("Edit block contents")
is possibly misleading, because it might not be the contents of
the _current_ block that's being navigated to, but rather that
of a sibling or parent block.
|
Marking as draft, as somehow I lost a big chunk of code in last commit! |
|
Turns out this PR is fine; it was my local branch that I had somehow got in to some werid state that was not building. |
| OUT = 'out', | ||
| UP = 'up', | ||
| DOWN = 'down', | ||
| RIGHT = 'righ', |
There was a problem hiding this comment.
Suggested change
| RIGHT = 'righ', | |
| RIGHT = 'right', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an "Edit block contents (→)" block context menu option. This is shown any time the cursor is on a block and not in the rightmost position 'on the current line'; consequently the description may sometimes be slightly misleading, because it might not be the contents of the current block that's being navigated to, but rather that of a sibling or parent block. The menu option weights are adjusted to put edit between insert and delete.
Also:
LineCursorare not renamed, as that seems like a riskier change.)navigation_controller.ts.Part of #132.