Fix various issues with debug_lines parsing, and support DWARF5 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
peadar
force-pushed
the
fix5
branch
3 times, most recently
from
5585e87
to
da5d7de
Compare
|
CLA issues should be sorted - any opinions on this? |
Do this for all CUs, not just the first one. A previous incarnation of the DWARF parser didn't seem to separate out the translation units, and would implicitly iterate all. The change to making compilation units more visibile seems to have broken this.
This attribute is a LEB128 encoded value - decode it as such. Later use of attributes of this form may need some work, but without parsing it correctly, we break parsing of further attributes completely.
There are some differences between the DWARF4 and DWARF5 .debug_lines table format. Implement the DWARF5 changes. Mostly, the changes are to make the parser aware of the more sophisticated format of the directory and file tables, with some minor conditional changes in the header itself.
|
Thanks for the fixes. If possible, it would be really helpful to add yaml2obj tests. We don't currently have any for |
|
Sure, let me take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes '-d inlines' support for ELF, and also allows it work with DWARF5 - fixes #311