Skip to content

Commit

Permalink
Merge pull request #385 from carlocab/abseil-link
Browse files Browse the repository at this point in the history 
Link `absl::demangle_internal`
  • Loading branch information
@haberman
haberman authored Aug 28, 2024
2 parents 6b78e08 + 901cd48 commit 379d530
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CMakeLists.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ if(NOT absl_FOUND)
endif()
list(APPEND LIBBLOATY_LIBS absl::strings)
list(APPEND LIBBLOATY_LIBS absl::optional)
list(APPEND LIBBLOATY_LIBS absl::demangle_internal)
list(APPEND LIBBLOATY_LIBS Threads::Threads)

if(DEFINED ENV{LIB_FUZZING_ENGINE})
Expand Down
2 changes: 1 addition & 1 deletion third_party/abseil-cpp
Submodule abseil-cpp updated 4 files
+2 −1 CMake/AbseilHelpers.cmake
+2 −1 absl/debugging/failure_signal_handler.cc
+8 −0 absl/strings/internal/str_format/arg.h
+3 −0 absl/strings/internal/str_format/convert_test.cc

1 comment on commit 379d530

@CJxD
Copy link

@CJxD CJxD commented on 379d530 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haberman I believe this caused an error in the build. I saw this error on my Clang 17 CI today:

 > [3/3] RUN git clone --recursive --depth 1 --branch main https://github.com/google/bloaty bloaty-src &&   cd bloaty-src &&   cmake . -G Ninja &&   ninja install -j 1 bloaty &&   cd .. && rm -rf bloaty-src:
470.7       |           FormatConversionCharInternal
470.7 /bloaty-src/third_party/abseil-cpp/absl/strings/internal/str_format/extension.cc:55:11: error: 'FormatConversionCharSet' does not name a type; did you mean 'FormatConversionCharInternal'?
470.7    55 | constexpr FormatConversionCharSet FormatConversionCharSetInternal::kNumeric;
470.7       |           ^~~~~~~~~~~~~~~~~~~~~~~
470.7       |           FormatConversionCharInternal
470.7 /bloaty-src/third_party/abseil-cpp/absl/strings/internal/str_format/extension.cc:57:11: error: 'FormatConversionCharSet' does not name a type; did you mean 'FormatConversionCharInternal'?
470.7    57 | constexpr FormatConversionCharSet FormatConversionCharSetInternal::kPointer;
470.7       |           ^~~~~~~~~~~~~~~~~~~~~~~
470.7       |           FormatConversionCharInternal
470.7 ninja: build stopped: subcommand failed.

Please sign in to comment.